Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce concept of projection cache 'completion' #89831

Merged
merged 1 commit into from
Dec 19, 2021

Commits on Dec 19, 2021

  1. Re-introduce concept of projection cache 'completion'

    Instead of clearing out the cache entirely, we store
    the intermediate evaluation result into the cache entry.
    This accomplishes several things:
    
    * We avoid the performance hit associated with re-evaluating
      the sub-obligations
    * We avoid causing issues with incremental compilation, since
      the final evaluation result is always the same
    * We avoid affecting other uses of the same `InferCtxt` which
      might care about 'side effects' from processing the sub-obligations
      (e,g. region constraints). Only code that is specifically aware
       of the new 'complete' code is affected
    Aaron1011 committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    40ef1d3 View commit details
    Browse the repository at this point in the history