Make llvm.download-ci-llvm="if-available" work for tier 2 targets with host tools
#89888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
hkratz
changed the title
rust.download-ci-llvm="if-available" work for aarch64-apple-darwinllvm.download-ci-llvm="if-available" work for aarch64-apple-darwin
|
Hm. In theory, the list of targets is probably the tier 2 with host tools -- roughly (or "better"). We can probably add all of those listed there -- https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-2-with-host-tools I don't think we need automate the if-available set but that seems like a better delta here probably? |
Mark-Simulacrum
added
S-waiting-on-author
hkratz
changed the title
llvm.download-ci-llvm="if-available" work for aarch64-apple-darwinllvm.download-ci-llvm="if-available" work for tier 2 platforms with host tools
hkratz
force-pushed
the
download-ci-llvm-apple-arm64
branch
from
16d1aec to
ac298c9
Compare
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
|
PR description edited and force-pushed to include all tier 2 targets with host tools. |
hkratz
changed the title
llvm.download-ci-llvm="if-available" work for tier 2 platforms with host toolsllvm.download-ci-llvm="if-available" work for tier 2 targets with host tools
|
@bors r+ rollup Thanks! |
|
📌 Commit ac298c9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#89738 (ty::pretty: prevent infinite recursion for `extern crate` paths.) - rust-lang#89888 (Make `llvm.download-ci-llvm="if-available"` work for tier 2 targets with host tools) - rust-lang#89945 (Remove a mention to `copy_from_slice` from `clone_from_slice` doc) - rust-lang#89946 (Fix an ICE with TAITs and Future) - rust-lang#89963 (Some "parenthesis" and "parentheses" fixes) - rust-lang#89975 (Add a regression test for rust-lang#85921) - rust-lang#89977 (Make Result::as_mut const) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm.download-ci-llvm="if-available"is used for most profiles configured viax.py setup. It allows downloading prebuilt LLVM tarballs from the CI artifacts for a configured list of platforms. Currently this list is restricted to tier 1 targets but it makes sense for all tier 2 targets with host tools.