Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emitter: current substitution can be multi-line #89912

Merged

Commits on Oct 15, 2021

  1. emitter: current substitution can be multi-line

    In `splice_lines`, there is some arithmetic to compute the required
    alignment such that future substitutions in a suggestion are aligned
    correctly. However, this assumed that the current substitution's span
    was only on a single line. In circumstances where this was not true, it
    could result in a arithmetic overflow when the substitution's end
    column was less than the substitution's start column.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d2dc0f3 View commit details
    Browse the repository at this point in the history