Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] libtest: Use atty crate instead of rolling our own #90094

Closed
wants to merge 1 commit into from
Closed

[WIP] libtest: Use atty crate instead of rolling our own #90094

wants to merge 1 commit into from

Conversation

diohabara
Copy link

@diohabara diohabara commented Oct 20, 2021 •
edited
Loading

Related issue: #80937

TODO

  • Find where to add a dependency
  • Add atty

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2021
@diohabara diohabara changed the title libtest: Use atty crate instead of rolling our own [WIP] libtest: Use atty crate instead of rolling our own Oct 20, 2021
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2021
@crlf0710 crlf0710 marked this pull request as draft November 5, 2021 15:26
@Dylan-DPC
Copy link
Member

Closing this as inactive. If you make any progress on this, feel free to open a new PR

@Dylan-DPC Dylan-DPC closed this Feb 19, 2022
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diohabara @rust-highfive @Dylan-DPC @Mark-Simulacrum @jyn514