Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of method headings for scannability #90155

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Fix alignment of method headings for scannability #90155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions src/librustdoc/html/static/css/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,15 @@ h1.fqn > .in-band > a:hover {
h2, h3, h4 {
border-bottom: 1px solid;
}
h3.code-header, h4.code-header {
h3.code-header {
font-size: 1.1em;
}
h4.code-header {
font-size: 1em;
}
h3.code-header, h4.code-header {
font-weight: 600;
border: none;
border-bottom-style: none;
padding: 0;
margin: 0;
}
Expand All @@ -174,12 +179,6 @@ h3.code-header, h4.code-header {
margin-bottom: 10px;
position: relative;
}
.impl, .method.trait-impl,
.type.trait-impl,
.associatedconstant.trait-impl,
.associatedtype.trait-impl {
padding-left: 15px;
}

div.impl-items > div {
padding-left: 0;
Expand Down Expand Up @@ -669,13 +668,6 @@ nav.sub {
left: -19px;
}

.content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant,
.impl-items > .associatedtype, .content .impl-items details > summary > .type,
.impl-items details > summary > .associatedconstant,
.impl-items details > summary > .associatedtype {
margin-left: 20px;
}

.content .impl-items .docblock, .content .impl-items .item-info {
margin-bottom: .6em;
}
Expand Down Expand Up @@ -746,7 +738,7 @@ a {
.anchor {
display: none;
position: absolute;
left: 0;
left: -0.5em;
background: none !important;
}
.anchor.field {
Expand Down Expand Up @@ -1579,14 +1571,14 @@ details.rustdoc-toggle > summary.hideme::before {

details.rustdoc-toggle > summary:not(.hideme)::before {
position: absolute;
left: -23px;
left: -24px;
top: 3px;
}

.impl-items > details.rustdoc-toggle > summary:not(.hideme)::before,
.undocumented > details.rustdoc-toggle > summary:not(.hideme)::before {
position: absolute;
left: -2px;
left: -24px;
}

/* When a "hideme" summary is open and the "Expand description" or "Show
Expand Down
11 changes: 11 additions & 0 deletions src/test/rustdoc-gui/anchor-navigable.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// The `impl Foo` heading underneath `Implementations` has a §
// anchor to its left (used for linking to that heading). The anchor only shows
// up when hovering the `impl Foo`. This test ensures there's no gap between the
// anchor and the `impl Foo`. If there were a gap, this would cause an annoying
// problem: you hover `impl Foo` to see the anchor, then when you move your
// mouse to the left, the anchor disappears before you reach it.
goto: file://|DOC_PATH|/test_docs/struct.Foo.html
// We check that ".item-info" is bigger than its content.
move-cursor-to: ".impl"
assert-property: (".impl > a.anchor", {"offsetWidth": "9"})
assert-css: (".impl > a.anchor", {"left": "-8px"})