fix(rustc_typeck): report function argument errors on matching type #90181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/error-pointer
branch
from
79324d5
to
7c37697
Compare
|
r? @estebank |
|
CC @nagisa Not sure how to assign to both of you? |
estebank
reviewed
Oct 24, 2021
estebank
reviewed
Oct 24, 2021
|
r=me after squashing |
|
☔ The latest upstream changes (presumably #90249) made this pull request unmergeable. Please resolve the merge conflicts. |
notriddle
force-pushed
the
notriddle/error-pointer
branch
from
7c37697
to
8520105
Compare
|
@bors r+ |
|
📌 Commit 8520105 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2021
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#90181 (fix(rustc_typeck): report function argument errors on matching type) - rust-lang#90241 (Make thiscall abi on unsupported platforms a hard error) - rust-lang#90294 (Update books) - rust-lang#90295 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2021
… r=JohnTitor Add regression test for issue 90164 Closes rust-lang#90164 (previously fixed by rust-lang#90181)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2021
… r=JohnTitor Add regression test for issue 90164 Closes rust-lang#90164 (previously fixed by rust-lang#90181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90101