Tooltip overflow #90233
Tooltip overflow #90233
Conversation
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
r=me after fixing the selector. It might not be necessary, but it seems that removing the * is preferred by MDN and Firefox devtools. When I tried to enter .docblock > *:not(.information) into the devtools before, it changed it to .docblock > :not(.information).
| @@ -528,7 +528,7 @@ nav.sub { | |||
| position: relative; | |||
| } | |||
|
|
|||
| .docblock > * { | |||
| .docblock > *:not(.information) { | |||
There was a problem hiding this comment.
I think this should be the following:
| .docblock > *:not(.information) { | |
| .docblock > :not(.information) { |
See https://developer.mozilla.org/en-US/docs/Web/CSS/:not#examples for more.
camelid
added
S-waiting-on-author
|
And also: please squash your commits :) Adding the test as part of the fix commit makes it easier to understand the change later on. |
Ah right, I forgot we disagreed on this point. Well, since you're the reviewer I'll do it. ;) |
GuillaumeGomez
force-pushed
the
tooltip-overflow
branch
from
df57514 to
345519b
Compare
|
@bors: r=camelid rollup |
|
📌 Commit 345519b has been approved by |
bors
added
S-waiting-on-bors
…camelid Tooltip overflow Fixes rust-lang#89185. r? `@camelid`
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#90017 (Add a couple tests for normalize under binder issues) - rust-lang#90079 (enable `i8mm` target feature on aarch64 and arm) - rust-lang#90233 (Tooltip overflow) - rust-lang#90257 (Changed slice.swap documentation for better readability) - rust-lang#90261 (Move back to linux builder on try builds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #89185.
r? @camelid