rustdoc: use better highlighting for *const, *mut, and &mut #90278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generates more consistent HTML for these RefKeyWord combinations. Before:  After: 
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hmm, I wonder if there's a way to do this consistently for all keywords instead of special casing const/mut and pointers. Could rustdoc maybe combine all adjacent keywords into the same span? That would shrink the HTML for things like |
|
The |
|
Oh, I didn't notice the color difference. This seems fine then. |
GuillaumeGomez
approved these changes
Oct 26, 2021
|
Thanks! @bors: r=jyn541,GuillaumeGomez |
|
📌 Commit 3a79370 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 3a79370 with merge f57ee2905238da57edf2c5aea2e7e5115ac4a78d... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
This is a spurrious error, right? I found a similar error on another PR, and it merged after a retry. |
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2021
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90154 (rustdoc: Remove `GetDefId`) - rust-lang#90232 (rustdoc: Use TTF based font instead of OTF for CJK glyphs to improve readability) - rust-lang#90278 (rustdoc: use better highlighting for *const, *mut, and &mut) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
camelid
added
the
T-rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates more consistent HTML for these RefKeyWord combinations.
Before:
After: