Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded into_iter #90302

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Remove unneeded into_iter #90302

merged 1 commit into from
Oct 26, 2021

Conversation

GuillaumeGomez
Copy link
Member

As @camelid mentionned here, the into_iter was unneeded.

r? @camelid

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 26, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2021
@jyn514
Copy link
Member

jyn514 commented Oct 26, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2021

📌 Commit cdee839 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 26, 2021
@matthiaskrgr
Rollup merge of rust-lang#90302 - GuillaumeGomez:rm-unneeded-into_ite…
5feb198 
…r, r=jyn514

Remove unneeded into_iter

As `@camelid` mentionned [here](rust-lang#89430 (comment)), the `into_iter` was unneeded.

r? `@camelid`
This was referenced Oct 26, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2021
@bors
Auto merge of rust-lang#90314 - matthiaskrgr:rollup-ag1js8n, r=matthi…
e269e6b 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#90296 (Remove fNN::lerp)
 - rust-lang#90302 (Remove unneeded into_iter)
 - rust-lang#90303 (Add regression test for issue 90164)
 - rust-lang#90305 (Add regression test for rust-lang#87258)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 76392fb into rust-lang:master Oct 26, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 26, 2021
@GuillaumeGomez GuillaumeGomez deleted the rm-unneeded-into_iter branch October 26, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@camelid camelid

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @jyn514 @bors @rust-highfive @camelid @rustbot