Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid needless memcpy for codeblock #90332

Closed

Conversation

Mark-Simulacrum
Copy link
Member

Following up on #85833, but probably not actually directly related.

r? @ghost until we get (potentially) positive perf

@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 27, 2021
@bors
Copy link
Contributor

bors commented Oct 27, 2021

⌛ Trying commit 745ab1a with merge b540e394ce589b5d0dbafd8632c8fa5565f71eb5...

@bors
Copy link
Contributor

bors commented Oct 27, 2021

☀️ Try build successful - checks-actions
Build commit: b540e394ce589b5d0dbafd8632c8fa5565f71eb5 (b540e394ce589b5d0dbafd8632c8fa5565f71eb5)

@rust-timer
Copy link
Collaborator

Queued b540e394ce589b5d0dbafd8632c8fa5565f71eb5 with parent e269e6b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b540e394ce589b5d0dbafd8632c8fa5565f71eb5): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants