Add some GATs-related regression tests #90678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Can you add the bounds the test outputs say to? So they either pass or fail during type checking. |
JohnTitor
force-pushed
the
add-some-gats-tests
branch
from
b1c3002
to
186e2a4
Compare
|
Sure, updated as suggsted. |
jackh726
approved these changes
Nov 8, 2021
| trait A<'a> { | ||
| type B<'b>: Clone | ||
| where | ||
| 'a: 'b, Self: 'a, Self: 'b; |
There was a problem hiding this comment.
Oh uh...right. can you add a FIXME(generic_associated_types) here to remove one of these bounds? It's currently unresolved for the outlives lint and I don't want to miss this after that is resolved.
JohnTitor
force-pushed
the
add-some-gats-tests
branch
from
186e2a4
to
ebd401b
Compare
|
@bors r=jackh726 rollup+ |
|
📌 Commit ebd401b has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#87530 (Add comments regarding superfluous `!Sync` impls) - rust-lang#90591 (treat illumos like solaris in failing ui tests which need it) - rust-lang#90678 (Add some GATs-related regression tests) - rust-lang#90688 (enable `dotprod` target feature in arm) - rust-lang#90708 (Add a note about feature(explicit_generic_args_with_impl_trait) to the relevant error message) - rust-lang#90720 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88595, closes #90014
r? @jackh726