kmc-solid: Avoid the use of asm_const
#90690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Out of interest, why this choice over enabling the relevant feature gate for std? |
|
Similar to #90348 (comment) - with the stage0 compiler not knowing about |
|
Seems ok. I would've expected a cfg_attr(not(bootstrap), feature(asm_const)) to work, but I may be missing something. This also seems fine in the meantime anyway. @bors r+ rollup |
|
📌 Commit f170770 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 10, 2021
…=Mark-Simulacrum kmc-solid: Avoid the use of `asm_const` This PR removes the use of [the now-separated-out `asm_const` compiler feature][1] in `std::sys::solid` to fix the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets. [1]: rust-lang#90348
This was referenced Nov 10, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2021
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90690 (kmc-solid: Avoid the use of `asm_const`) - rust-lang#90748 (Add a real tracking issue for `CommandExt::groups`) - rust-lang#90751 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
yanok
pushed a commit
to yanok/rust
that referenced
this pull request
Nov 10, 2021
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90690 (kmc-solid: Avoid the use of `asm_const`) - rust-lang#90748 (Add a real tracking issue for `CommandExt::groups`) - rust-lang#90751 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of the now-separated-out
asm_constcompiler feature instd::sys::solidto fix the*-kmc-solid_*Tier 3 targets.