Skip to content

Conversation

asterycs
Copy link
Contributor

closes #90768

I grep:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2021
@michaelwoerister
Copy link
Member

Nice find! Thanks, @asterycs, looks good to me.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 11, 2021

📌 Commit fc9624c has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 11, 2021
…e, r=michaelwoerister

Fix trait object error code

closes rust-lang#90768

I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
the8472 added a commit to the8472/rust that referenced this pull request Nov 11, 2021
…e, r=michaelwoerister

Fix trait object error code

closes rust-lang#90768

I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
@bors
Copy link
Collaborator

bors commented Nov 12, 2021

⌛ Testing commit fc9624c with merge 3a46dc80a40d34c7169c973c63a7719cd9ee2e67...

hellow554 added a commit to hellow554/rust that referenced this pull request Nov 12, 2021
…e, r=michaelwoerister

Fix trait object error code

closes rust-lang#90768

I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
@bors
Copy link
Collaborator

bors commented Nov 12, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@kennytm
Copy link
Member

kennytm commented Nov 13, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
…e, r=michaelwoerister

Fix trait object error code

closes rust-lang#90768

I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
…e, r=michaelwoerister

Fix trait object error code

closes rust-lang#90768

I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2021
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90771 (Fix trait object error code)
 - rust-lang#90840 (relate lifetime in `TypeOutlives` bounds on drop impls)
 - rust-lang#90853 (rustdoc: Use an empty Vec instead of Option<Vec>)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b35af0d into rust-lang:master Nov 14, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error code when using a trait object without dyn
8 participants