Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak errors coming from for-loop, ? and .await desugaring #90939

Merged
merged 16 commits into from
Dec 15, 2021
Merged

Tweak errors coming from for-loop, ? and .await desugaring #90939

merged 16 commits into from
Dec 15, 2021

Commits on Dec 13, 2021

  1. When .await is called on a non-Future expression, suggest removal 

    Keep track of the origin of a `T: Future` obligation when caused by an
`.await` expression.

Address rust-lang#66731.
    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    7227a87 View commit details
    Browse the repository at this point in the history

  2. Reduce verbosity when calling for-loop on non-Iterator expression

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    75b6275 View commit details
    Browse the repository at this point in the history

  3. Reduce verbosity for ? on non-Try expressions

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    caf0c1b View commit details
    Browse the repository at this point in the history

  4. Further silence ? errors

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    81a3b90 View commit details
    Browse the repository at this point in the history

  5. Remove yet more output from for-loop and ? errors

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    79749d6 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary argument

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    4f2b1c0 View commit details
    Browse the repository at this point in the history

  7. Fix mistake

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d45e030 View commit details
    Browse the repository at this point in the history

  8. Keep info on pre-desugaring expression for better "incorrect .await… 

    …" suggestion

Keep the `HirId` of `.await`ed expressions so in the case of a `fn` call
on on a sync `fn`, we can suggest maybe turning it into an `async fn`.
    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f640438 View commit details
    Browse the repository at this point in the history

  9. Fix clippy uses of QPath::LangItem

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8888d0d View commit details
    Browse the repository at this point in the history

  10. Fix rebase and clippy tests

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    b825b0f View commit details
    Browse the repository at this point in the history

  11. tidy fix

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    9ecb141 View commit details
    Browse the repository at this point in the history

  12. Simplify diagnostic logic 

    The spans no longer overlap, so we no longer need to specialize the
output depending on whether they would.
    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d59f74a View commit details
    Browse the repository at this point in the history

  13. review comments

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    64dea33 View commit details
    Browse the repository at this point in the history

  14. review comment: change wording of suggestion

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1a7f2d5 View commit details
    Browse the repository at this point in the history

  15. fix clippy tests

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    64f88e8 View commit details
    Browse the repository at this point in the history

  16. fix coverage report test

    @estebank
    estebank committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f2fc84f View commit details
    Browse the repository at this point in the history