Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for evaluate_obligation: Ok(EvaluatedToOkModuloRegions) ICE #91065

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Add test for evaluate_obligation: Ok(EvaluatedToOkModuloRegions) ICE #91065

merged 3 commits into from
Dec 7, 2021

Commits on Dec 4, 2021

  1. Add test for evaluate_obligation: Ok(EvaluatedToOkModuloRegions) ICE 

    Adds the minimial repro test case from rust-lang#85360. The fix for rust-lang#85360 was
supposed to be rust-lang#85868 however the repro was resolved in the 2021-07-05
nightly while rust-lang#85360 didn't land until 2021-09-03. The reason for that
is d34a3a4 **also** resolves that
issue.

To test if rust-lang#85868 actually fixes rust-lang#85360, I reverted
d34a3a4 and found that rust-lang#85868 does
indeed resolve rust-lang#85360.

With that question resolved, add a test case to our incremental test
suite for the original Ok(EvaluatedToOkModuloRegions) ICE.

Thanks to @lqd for helping track this down!
    @wesleywiser
    wesleywiser committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    14c6193 View commit details
    Browse the repository at this point in the history

  2. Add test with #[rustc_evaluate_where_clauses] 

    As suggested via reviewer feedback.
    @wesleywiser
    wesleywiser committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    98e9b32 View commit details
    Browse the repository at this point in the history

  3. Add test case that evals to EvaluatedToOkModuloRegions

    @wesleywiser
    wesleywiser committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    6fe13f6 View commit details
    Browse the repository at this point in the history