Update Clippy #91154

flip1995 · 2021-11-23T10:49:26Z

Delayed Clippy sync. I didn't get to it over the weekend..

…, r=flip1995 Reference `clippy_utils` docs on nightly-rustc and some other documentation updates The `clippy_utils` crate is now part of the nightly-rustc documentation. See [**very beautiful documentation**](https://doc.rust-lang.org/nightly/nightly-rustc/clippy_utils/). This PR references them in our documentation and updates some other documentation. changelog: none

Fix false negative in [`match_overlapping_arms`] changelog: Fix false negative in [`match_overlapping_arms`]

Replace `in_macro` usage with `from_expansion` changelog: none Generally replace `in_macro(span)` with `span.from_expansion()`. If we're just trying to avoid expanded code, this seems more appropriate because any kind of expanded code is prone to false positives. One place I did not touch is `macro_use.rs`. I think this lint could use a rewrite so I moved `in_macro` there, the only place it is still used.

…shearth Remove rustfmt::skip attribute from register_plugins function r? `@Manishearth` since you added this in rust-lang#540 😄 changelog: none

I found the manual run command really useful, this makes it a bit easier to type

…effen Extend author lint changelog: none * Print float and int suffixes * Print labels * Struct field checks * Repeat length expression check * Destructure method calls * Destructure closures

Add `cargo dev lint` to manually run clippy on a file I found the manual run command really useful, this makes it a bit easier to type Not sure if this belongs in the changelog or not changelog: Add `cargo dev lint` to manually run clippy on a file

TraitKind -> Trait TyAliasKind -> TyAlias ImplKind -> Impl FnKind -> Fn All `*Kind`s in AST are supposed to be enums. Tuple structs are converted to braced structs for the types above, and fields are reordered in syntactic order. Also, mutable AST visitor now correctly visit spans in defaultness, unsafety, impl polarity and constness.

The only reason to use `abort_if_errors` is when the program is so broken that either: 1. later passes get confused and ICE 2. any diagnostics from later passes would be noise This is never the case for lints, because the compiler has to be able to deal with `allow`-ed lints. So it can continue to lint and compile even if there are lint errors.

Fix ICE in undocumented_unsafe_blocks changelog: Fix ICE in [`undocumented_unsafe_blocks`] closes: rust-lang#7934

Introduce `expr_visitor` and `expr_visitor_no_bodies` changelog: none A couple utils that satisfy a *lot* of visitor use cases. Factoring in every possible usage would be really big so I just focused on cleaning clippy_utils.

Rustup Re-sync, because I didn't get to syncing things back to rustc. r? `@ghost` changelog: none

rust-highfive · 2021-11-23T10:49:29Z

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Manishearth · 2021-11-23T15:42:02Z

@bors r+

bors · 2021-11-23T15:42:04Z

📌 Commit b95545b has been approved by Manishearth

Update Clippy r? `@Manishearth` Delayed Clippy sync. I didn't get to it over the weekend..

matthiaskrgr · 2021-11-23T18:29:20Z

@bors p=1 (kinda bitrotty)

bors · 2021-11-24T03:00:11Z

⌛ Testing commit b95545b with merge 64a23715ae719461cd7759c26ed1a98f513e540a...

rust-log-analyzer · 2021-11-24T03:32:56Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    |
note: function defined here
   --> /checkout/src/tools/clippy/clippy_lints/src/lib.rs:414:8
    |
414 | pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] rls_rustc test:false 0.420
error: could not compile `rls-rustc` due to previous error
---
Verifying status of rls...
Verifying status of miri...
Verifying status of embedded-book...
Cloning into 'rust-toolstate'...
error: Tool `rls` has regressed from test-pass to build-fail during beta week.
{"rust-by-example":"test-pass","rustbook":"test-fail","embedded-book":"test-pass","book":"test-pass","edition-guide":"test-pass","reference":"test-pass","nomicon":"test-pass","miri":"test-pass","cargo-miri":"test-fail","rls":"build-fail"}Build completed unsuccessfully in 0:00:00

bors · 2021-11-24T03:33:42Z

💔 Test failed - checks-actions

camsteffen · 2021-11-24T14:48:44Z

error[E0061]: this function takes 3 arguments but 1 argument was supplied
   --> src/tools/rls/rls-rustc/src/clippy.rs:62:9
    |
62  |         clippy_lints::register_pre_expansion_lints(&mut lint_store);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ --------------- supplied 1 argument
    |         |
    |         expected 3 arguments

Did this function change?

flip1995 · 2021-11-24T15:32:06Z

Yes 413d255 changed that function. So we will have to do a RLS sync first.

flip1995 · 2021-11-24T15:56:48Z

Ohoh, we can't update RLS, because we can't bump the Clippy version, because the Clippy packages have edition 2021, so cargo complains that it can't find them:

cargo update -p clippy_lints
    Updating git repository `https://github.com/rust-lang/rust-clippy`
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/rust-clippy`
error: no matching package named `clippy_lints` found
location searched: https://github.com/rust-lang/rust-clippy?rev=0c8799da5aabf72aee26053075d2bd73ef9f7789
required by package `rls v1.41.0 (/home/pkrones/rust-lang/rls)`

Let's investigate...

flip1995 · 2021-11-30T14:11:46Z

Since we missed the time frame to get this into this release, I will close this in favor of the sync I'll do on Thursday.

Michael Wright and others added 30 commits November 1, 2021 06:12

Fix match_overlapping_arm false negative

c3d4577

Fixes rust-lang#7816

Ensure match_overlapping_arms warns on first

693df63

Reference nightly-rustc docs in clippy's docs

1011e08

Improve clippy_utils function docs

d134ddd

Add clippy docs to check for a specific type

a276cd2

Added note about the usage of clippy_utils::path

5405152

Merge commit 'e18101137866b79045fee0ef996e696e68c920b4' into clippyup

e674d0a

Remove rustfmt::skip attribute from register_plugins function

93ffc9d

Use Span::from_expansion instead of in_macro

14d54f0

Auto merge of rust-lang#7909 - mikerite:fix-7816, r=camsteffen

85e2592

Fix false negative in [`match_overlapping_arms`] changelog: Fix false negative in [`match_overlapping_arms`]

Edit docs about macros

5b1b6a2

Auto merge of rust-lang#7937 - flip1995:rustfmt-skip-artefact, r=Mani…

445c83f

…shearth Remove rustfmt::skip attribute from register_plugins function r? `@Manishearth` since you added this in rust-lang#540 😄 changelog: none

Remove trim_semicolon

1c4dd8d

Add expr_visitor util

73501da

Factor in some expr_visitor usages

5239a90

Remove if let check for match_ref_pats

2c7b7e8

Extend author lint

c96cd35

Add cargo dev lint to manually run clippy on a file

b5bae09

I found the manual run command really useful, this makes it a bit easier to type

Auto merge of rust-lang#7894 - Serial-ATA:extend-author-lint, r=camst…

e3d1e60

…effen Extend author lint changelog: none * Print float and int suffixes * Print labels * Struct field checks * Repeat length expression check * Destructure method calls * Destructure closures

Fix Clippy with changed format_args!

9a8919d

Give inline const separate DefKind

0cb9ac2

Fix ICE in undocumented_unsafe_blocks

2c6f03d

Auto merge of rust-lang#7945 - Serial-ATA:issue-7934, r=flip1995

6fcdf81

Fix ICE in undocumented_unsafe_blocks changelog: Fix ICE in [`undocumented_unsafe_blocks`] closes: rust-lang#7934

Make select_* methods return Vec for TraitEngine

6d23824

Auto merge of rust-lang#8025 - flip1995:rustup, r=flip1995

81f37a8

Rustup Re-sync, because I didn't get to syncing things back to rustc. r? `@ghost` changelog: none

rust-highfive assigned Manishearth Nov 23, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2021

This comment has been minimized.

Sign in to view

flip1995 added 2 commits November 23, 2021 12:06

Merge commit '81f37a8150fc86f8de00e6947e86d2b69291906a' into clippyup

1ee5aa4

Update Cargo.lock

b95545b

flip1995 force-pushed the clippyup branch from 6aedd35 to b95545b Compare November 23, 2021 11:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2021

matthiaskrgr mentioned this pull request Nov 23, 2021

Rollup of 7 pull requests #91157

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 23, 2021

Rollup merge of rust-lang#91154 - flip1995:clippyup, r=Manishearth

c9ce710

Update Clippy r? `@Manishearth` Delayed Clippy sync. I didn't get to it over the weekend..

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2021

flip1995 mentioned this pull request Nov 24, 2021

Bump nightly, clippy and rustfmt versions rust-lang/rls#1753

Merged

camelid added the A-clippy Area: Clippy label Nov 25, 2021

flip1995 closed this Nov 30, 2021

flip1995 deleted the clippyup branch November 30, 2021 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #91154

Update Clippy #91154

flip1995 commented Nov 23, 2021

rust-highfive commented Nov 23, 2021

This comment has been minimized.

Manishearth commented Nov 23, 2021

bors commented Nov 23, 2021

matthiaskrgr commented Nov 23, 2021

bors commented Nov 24, 2021

rust-log-analyzer commented Nov 24, 2021

bors commented Nov 24, 2021

camsteffen commented Nov 24, 2021

flip1995 commented Nov 24, 2021

flip1995 commented Nov 24, 2021

flip1995 commented Nov 30, 2021

Update Clippy #91154

Update Clippy #91154

Conversation

flip1995 commented Nov 23, 2021

rust-highfive commented Nov 23, 2021

This comment has been minimized.

Manishearth commented Nov 23, 2021

bors commented Nov 23, 2021

matthiaskrgr commented Nov 23, 2021

bors commented Nov 24, 2021

rust-log-analyzer commented Nov 24, 2021

bors commented Nov 24, 2021

camsteffen commented Nov 24, 2021

flip1995 commented Nov 24, 2021

flip1995 commented Nov 24, 2021

flip1995 commented Nov 30, 2021