-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove eval_always for privacy_access_levels. #91295
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 76acc6aed7f6c191fb79fa8824d1c622fcba0e77 with merge 956e8e72f5863bf517d5b48ff06982077631673b... |
☀️ Try build successful - checks-actions |
Queued 956e8e72f5863bf517d5b48ff06982077631673b with parent 5fd3a5c, future comparison URL. |
Finished benchmarking commit (956e8e72f5863bf517d5b48ff06982077631673b): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
r? @Aaron1011