Add needs-unwind to tests that depend on panicking #91373

djkoloski · 2021-11-29T22:46:58Z

These tests were found by running the test suite on fuchsia which compiles with panic=abort by default, then picking through the failures manually to locate the tests that require unwinding support.

Most of these tests are already opted-out on platforms that compile with panic=abort by default. This just generalizes it a bit more so that fuchsia tests can be run properly. Currently, the needs-unwind directive needs to be manually passed to compiletest (e.g. via --test-args '--target-panic=abort'). Eventually, I would like x.py or compiletest to determine whether the directive should be used automatically based on the target panic settings.

rust-highfive · 2021-11-29T22:47:01Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

tmandry · 2021-11-29T23:31:35Z

You should also be able to remove the existing ignore-(platform) lines that are there because the platform is built without unwinding support.

djkoloski · 2021-11-30T00:29:12Z

I did that originally but the flag in compiletest needs a command-line argument (i.e. it's not inherently set for specific target configurations). Should we be pulling that setting from a config?

tmandry · 2021-11-30T18:58:14Z

Ah right, the plan was to add a flag to bootstrap that enables panic=abort and tells compiletest about it. That should be a separate change. I think this is fine for now.

src/test/ui/async-await/async-fn-size-moved-locals.rs

Mark-Simulacrum · 2021-12-03T01:29:08Z

I did that originally but the flag in compiletest needs a command-line argument (i.e. it's not inherently set for specific target configurations). Should we be pulling that setting from a config?

I forget what PR added needs-unwind (maybe my bad there), but if it's currently just not being used at all (which seems to be the case), it seems a little misleading to go through annotating tests with this flag, particularly when it "seems" like some of the ignore- flags would be removable with this flag added.

I also noted that the current target specs for fuchsia don't have a panic strategy of abort, so it seems like in general unwinding is supported?

I am not strictly opposed to merging this, but I would like a better understanding of the expectation on your end for integrating needs-unwind into actual invocations of compile test from our build system (rough sense of timeline), and maybe some commentary in the PR description for how these tests were found (did you run with a panic=abort flag and just blanket added for where it failed?). My review comment suggests that it's possible some unrelated tests were also adjusted in this PR, which seems best to avoid and is part of the reason I'd like the test selection rationale better documented in the PR.

(If I miss your comment, please @rustbot ready so the S-waiting-on-review label is set).

djkoloski · 2021-12-03T15:34:33Z

if it's currently just not being used at all (which seems to be the case), it seems a little misleading to go through annotating tests with this flag

There is a flag and it is functional, but it has to be manually passed (e.g. ./x.py test --test-args '--target-panic=abort'). It should really be pulled from the target specification instead, but I haven't done any work to get that up and running yet. Once the flag is automatically specified, I would be comfortable removing the target-specific ignore- directives.

I also noted that the current target specs for fuchsia don't have a panic strategy of abort, so it seems like in general unwinding is supported?

Although I believe it is now possible to build fuchsia with unwinding, I believe this was not always the case and the standard library is compiled with panic=abort by default. I can check with @tmandry on this.

I would like a better understanding of the expectation on your end for integrating needs-unwind into actual invocations of compile test

I expect that eventually x.py will automatically determine whether the needs-unwind directive applies to a target. Getting the Rust test suite running on fuchsia is my primary objective.

maybe some commentary in the PR description for how these tests were found

Updated.

My review comment suggests that it's possible some unrelated tests were also adjusted in this PR

Ack, you are correct. Those are fixes for other tests that failed on fuchsia, but are unrelated to this PR. They were added by mistake and I've removed them from this PR.

djkoloski · 2021-12-03T16:34:37Z

@rustbot ready

tmandry · 2021-12-03T18:46:53Z

For context, my plan was to add an explicit flag to x.py for building with panic=abort (ideally with defaults for the platforms that don't support it). This would modify compilation flags (including -Zpanic-abort-tests in the case of testing) as well as cause --target-panic=abort to be passed to compiletest.

It's true that adding the needs-unwind header while it's not fully functional could be misleading, but at least for now there wouldn't be any examples where it was there without the right platforms also being ignored explicitly. Eventually we would take those out.

Mark-Simulacrum · 2021-12-07T14:24:17Z

I'm okay proceeding here -- it sounds like we're on a good path toward this being integrated, and it's already ~usable directly, when needed.

@djkoloski it looks like an unrelated commit and a couple merges landed on this branch -- can you rebase those away? After that's done I expect to r+

This directive isn't automatically set by compiletest or x.py, but can be turned on manually for targets that require it.

djkoloski · 2021-12-09T22:05:27Z

Sorry about that, accidentally pulled in an unrelated commit. @rustbot ready

Mark-Simulacrum · 2021-12-09T22:09:58Z

@bors r+

bors · 2021-12-09T22:10:00Z

📌 Commit ea68758 has been approved by Mark-Simulacrum

…k-Simulacrum Add needs-unwind to tests that depend on panicking These tests were found by running the test suite on fuchsia which compiles with `panic=abort` by default, then picking through the failures manually to locate the tests that require unwinding support. Most of these tests are already opted-out on platforms that compile with `panic=abort` by default. This just generalizes it a bit more so that fuchsia tests can be run properly. Currently, the `needs-unwind` directive needs to be manually passed to compiletest (e.g. via `--test-args '--target-panic=abort'`). Eventually, I would like `x.py` or compiletest to determine whether the directive should be used automatically based on the target panic settings.

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#91127 (Add `<*{const|mut} T>::{to|from}_bits`) - rust-lang#91310 (Add --out-dir flag for rustdoc) - rust-lang#91373 (Add needs-unwind to tests that depend on panicking) - rust-lang#91426 (Make IdFunctor::try_map_id panic-safe) - rust-lang#91515 (Add rsplit_array variants to slices and arrays) - rust-lang#91553 (socket ancillary data implementation for dragonflybsd.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned Mark-Simulacrum Nov 29, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2021

djkoloski force-pushed the fuchsia_test_suite branch from 9b924d9 to ce8b18e Compare November 30, 2021 19:14

This comment has been minimized.

Sign in to view

djkoloski force-pushed the fuchsia_test_suite branch 2 times, most recently from a485fc8 to b3c1e65 Compare November 30, 2021 20:22

Mark-Simulacrum reviewed Dec 3, 2021

View reviewed changes

src/test/ui/async-await/async-fn-size-moved-locals.rs Outdated Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2021

djkoloski force-pushed the fuchsia_test_suite branch from b3c1e65 to 468c05c Compare December 3, 2021 15:33

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2021

apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Dec 9, 2021

Add needs-unwind to tests that depend on panicking

ea68758

This directive isn't automatically set by compiletest or x.py, but can be turned on manually for targets that require it.

djkoloski force-pushed the fuchsia_test_suite branch from 468c05c to ea68758 Compare December 9, 2021 22:04

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 9, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2021

matthiaskrgr mentioned this pull request Dec 10, 2021

Rollup of 7 pull requests #91727

Closed

matthiaskrgr mentioned this pull request Dec 11, 2021

Rollup of 6 pull requests #91776

Merged

bors merged commit f7278cf into rust-lang:master Dec 11, 2021

rustbot added this to the 1.59.0 milestone Dec 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add needs-unwind to tests that depend on panicking #91373

Add needs-unwind to tests that depend on panicking #91373

djkoloski commented Nov 29, 2021 •

edited

Loading

rust-highfive commented Nov 29, 2021

tmandry commented Nov 29, 2021

djkoloski commented Nov 30, 2021

tmandry commented Nov 30, 2021

This comment has been minimized.

Mark-Simulacrum commented Dec 3, 2021 •

edited

Loading

djkoloski commented Dec 3, 2021

djkoloski commented Dec 3, 2021

tmandry commented Dec 3, 2021 •

edited

Loading

Mark-Simulacrum commented Dec 7, 2021

djkoloski commented Dec 9, 2021

Mark-Simulacrum commented Dec 9, 2021

bors commented Dec 9, 2021

Add needs-unwind to tests that depend on panicking #91373

Add needs-unwind to tests that depend on panicking #91373

Conversation

djkoloski commented Nov 29, 2021 • edited Loading

rust-highfive commented Nov 29, 2021

tmandry commented Nov 29, 2021

djkoloski commented Nov 30, 2021

tmandry commented Nov 30, 2021

This comment has been minimized.

Mark-Simulacrum commented Dec 3, 2021 • edited Loading

djkoloski commented Dec 3, 2021

djkoloski commented Dec 3, 2021

tmandry commented Dec 3, 2021 • edited Loading

Mark-Simulacrum commented Dec 7, 2021

djkoloski commented Dec 9, 2021

Mark-Simulacrum commented Dec 9, 2021

bors commented Dec 9, 2021

djkoloski commented Nov 29, 2021 •

edited

Loading

Mark-Simulacrum commented Dec 3, 2021 •

edited

Loading

tmandry commented Dec 3, 2021 •

edited

Loading