Suggest the pat_param specifier before | on 2021 edition
#91385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
We have a migration warning but no lint for users who have enabled the new edition.
ecstatic-morse
force-pushed
the
pat-param-spec-suggest
branch
from
20e5371 to
4c1d317
Compare
This comment has been minimized.
This comment has been minimized.
|
The test in the third commit seems to be the same as the one in the second. I guess one is supposed to not have |
apiraino
added
the
T-compiler
|
Looks like a great improvement! |
|
@ecstatic-morse yeah, that seems like a preexisting mistake (the path implies that these might be duplicated to begin with). I would remove the edition flag on one of them (and rename it to make it clearer it is <=2018). r=me with that change and squashed commits. |
|
So there's already another pre-2021 test that is identical |
|
@bors r+ |
|
📌 Commit bfd95e1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90538 (Document how recursion is handled for `ty::Ty`) - rust-lang#90851 (Add unchecked downcast methods) - rust-lang#91209 (Implement ``@snapshot`` check for htmldocck) - rust-lang#91385 (Suggest the `pat_param` specifier before `|` on 2021 edition ) - rust-lang#91478 (Remove incorrect newline from float cast suggestion) - rust-lang#91481 (Use let_else in some more places in rustc_lint) - rust-lang#91488 (Fix ICE when `yield`ing in function returning `impl Trait`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this today after writing some Rust for the first time in a while.
r? @estebank