-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #91406
Rollup of 4 pull requests #91406
Conversation
…g atomic support.
Checking only their DefId doesn't work because all slices have the same fake DefId. Fixes rust-lang#91347
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Visit type in process_projection_elem. Instead of reimplementing it for each visitor.
Bump compiler_builtins to 0.1.55 to bring in fixes for targets lackin… …g atomic support. This fixes a "Cannot select" LLVM error when compiling `compiler_builtins` for targets lacking atomics, like MSP430. Se rust-lang/compiler-builtins#441 for more info. This PR is a more general version of rust-lang#91248.
…le-if-types-are-the-same, r=GuillaumeGomez Only show notable traits if both types are the same Checking only their DefId doesn't work because all slices have the same fake DefId. Fixes rust-lang#91347
…wiser Emit a warning on generic parameters with doc comments Fixes rust-lang#90610
@bors r+ rollup=never p=4 |
📌 Commit 7baafb1 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d384ff7): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
@matthiaskrgr this seems a bit hard to tell where the regression is coming from, but it is a quite a large regression in a real-world crate (albeit one that is a tiny bit noisy). #91366 and #91397 only really touch rustdoc so that's unlikely the culprit. PRs where code is removed or added can be a source of regressions so I wouldn't rule out the others, but we may want to investigate the bump of compiler builtins first. |
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup