Rollup of 6 pull requests #91539
Merged
Rollup of 6 pull requests #91539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is intended to follow the stabilization disposition of the FCP that has now finished in rust-lang#84223. This stabilizes the ability to flag thread local initializers as `const` expressions which enables the macro to generate more efficient code for accessing it, notably removing runtime checks for initialization. More information can also be found in rust-lang#84223 as well as the tests where the feature usage was removed in this PR. Closes rust-lang#84223
environ on macos uses directly libc which has the correct signature.
…arameter, r=jackh726 Explain why `Self` is invalid in generic parameters Close rust-lang#89985. r? `@estebank`
…ars, r=nikomatsakis Postpone the evaluation of constant expressions that depend on inference variables Previously `delay_span_bug` calls were triggered once an inference variable was included in the substs of a constant that was to be evaluated. Some of these would merely have resulted in trait candidates being rejected, hence no real error was ever encountered, but the triggering of the `delay_span_bug` then caused an ICE in later stages of the compiler due to no error ever occurring. We now postpone the evaluation of these constants, so any trait obligation fulfillment will simply stall on this constant and the existing type inference machinery of the compiler handles any type errors if present. Fixes rust-lang#89320 Fixes rust-lang#89146 Fixes rust-lang#87964 Fixes rust-lang#87470 Fixes rust-lang#83288 Fixes rust-lang#83249 Fixes rust-lang#90654 I want to thank `@BoxyUwU` for cooperating on this and for providing some help. r? `@lcnr` maybe?
…, r=m-ou-se Implement VecDeque::retain_mut Part of rust-lang#90829. In rust-lang#90772, someone suggested that `retain_mut` should also be implemented on `VecDeque`. I think that it follows the same logic (coherency). So first: is it ok? Second: should I create a new feature for it or can we put it into the same one? r? `@joshtriplett`
…-const, r=m-ou-se std: Stabilize the `thread_local_const_init` feature This commit is intended to follow the stabilization disposition of the FCP that has now finished in rust-lang#84223. This stabilizes the ability to flag thread local initializers as `const` expressions which enables the macro to generate more efficient code for accessing it, notably removing runtime checks for initialization. More information can also be found in rust-lang#84223 as well as the tests where the feature usage was removed in this PR. Closes rust-lang#84223
LLVM support .insn directive Closes rust-lang#90558. See also rust-lang/llvm-project#121.
|
@bors r+ rollup=never p=6 |
|
📌 Commit 2ba5917 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📣 Toolstate changed by #91539! Tested on commit 5e93f6e. 💔 miri on windows: test-pass → test-fail (cc @RalfJung @eddyb @oli-obk). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Dec 5, 2021
Tested on commit rust-lang/rust@5e93f6e. Direct link to PR: <rust-lang/rust#91539> 💔 miri on windows: test-pass → test-fail (cc @RalfJung @eddyb @oli-obk). 💔 miri on linux: test-pass → test-fail (cc @RalfJung @eddyb @oli-obk). 💔 rls on windows: test-pass → build-fail (cc @Xanewok). 💔 rls on linux: test-pass → build-fail (cc @Xanewok).
|
Finished benchmarking commit (5e93f6e): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Selfis invalid in generic parameters #90022 (Explain whySelfis invalid in generic parameters)thread_local_const_initfeature #91355 (std: Stabilize thethread_local_const_initfeature)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup