rustc_serialize: don't allocate Strings as key for BTreeMap, when str is enough
#91626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
klensy
changed the title
Strings as key for BTreeMap, when str is enought
|
@bors r+ |
|
📌 Commit 1b27b69 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 7, 2021
rustc_serialize: don't allocate `String`s as key for `BTreeMap`, when `str` is enought
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 8, 2021
rustc_serialize: don't allocate `String`s as key for `BTreeMap`, when `str` is enought
|
This should affect perf (at least, this is was idea), so @bors rollup=never |
|
@klensy: 🔑 Insufficient privileges: not in try users |
|
@bors rollup=never |
apiraino
added
the
T-compiler
camelid
changed the title
Strings as key for BTreeMap, when str is enoughtStrings as key for BTreeMap, when str is enough
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (6d6d089): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.