Skip to content

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Dec 11, 2021

  • Point at RHS of associated type in obligation span
  • Point at impl assoc type on projection error
  • Reduce verbosity of recursive obligations
  • Point at source of binding lifetime obligation
  • Tweak "required bound" note
  • Tweak "expected... found opaque (return) type" labels
  • Point at set type in impl assoc type WF errors

r? @oli-obk

This is a(n uncontroversial) subset of #85799.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2021
@estebank estebank force-pushed the type-trait-bound-span-2 branch from 9463d8d to c3d6db0 Compare December 11, 2021 02:31
* Point at RHS of associated type in obligation span
* Point at `impl` assoc type on projection error
* Reduce verbosity of recursive obligations
* Point at source of binding lifetime obligation
* Tweak "required bound" note
* Tweak "expected... found opaque (return) type" labels
* Point at set type in impl assoc type WF errors
@estebank estebank force-pushed the type-trait-bound-span-2 branch from c3d6db0 to 5e1972e Compare December 11, 2021 02:32
@oli-obk
Copy link
Contributor

oli-obk commented Dec 11, 2021

@bors r+ p=1 bitrotty

@bors
Copy link
Collaborator

bors commented Dec 11, 2021

📌 Commit 5e1972e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2021
@bors
Copy link
Collaborator

bors commented Dec 11, 2021

⌛ Testing commit 5e1972e with merge 229d0a9...

@bors
Copy link
Collaborator

bors commented Dec 12, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 229d0a9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2021
@bors bors merged commit 229d0a9 into rust-lang:master Dec 12, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 12, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (229d0a9): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants