add range_step/range_step_inclusive #9199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW and double check r+ 😄 |
bors
added a commit
that referenced
this pull request
Sep 15, 2013
My focus was on getting these to be correct in all cases by handling overflow properly. I'll clean them up and work on the performance later.
|
I think this line is wrong: "if (self.rev && self.state > self.stop) || self.state < self.stop" Shouldn't it be "if (self.rev && self.state > self.stop) || (!self.rev && self.state < self.stop)" or something equivalent instead? The tests don't catch it because the stop value is hit exactly in the only reverse test. |
|
@bill-myers: it was fixed in my follow-up commits, this is no longer the code used in the codebase |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 28, 2022
…rcho unused_self: respect avoid-breaking-exported-api ``` changelog: [`unused_self`]: Now respects the `avoid-breaking-exported-api` config option ``` Fixes rust-lang#9195. I mostly copied the implementation from `unnecessary_wraps`, since I don't have much understanding of rustc internals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My focus was on getting these to be correct in all cases by handling overflow properly. I'll clean them up and work on the performance later.