Use the RangeStep iterator and remove uint::range_step and friends
#9202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 15, 2013 06:08
Loops with negative step that didn't terminate evenly, i.e. overshot the stop value, didn't terminate at all. For example `range_step(28, -1, -4)`
Use the iterator version instead of the old uint::/int::range_step functions.
Replaced by `std::iter::range_step`
|
Stealing the last two commits for a new pull request fixing one more issue. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 28, 2022
Fix typo in alloc_instead_of_core The description previously claimed it ensures items are imported from alloc, to ensure a crate won't require alloc, which can't be true. I'm not sure know how to better phrase the changelog entry below. changelog: [`alloc_instead_of_core`]: fixed typo in description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
uint::range_step(and corresponding for all the other primitive numeric types) to thestd::iter::range_stepiterator.The first commit resolves an issue with negative steps when using the iterator.