-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #92060
Closed
Closed
Rollup of 7 pull requests #92060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a data section, the object crate will set SHF_ALLOC by default, which is exactly what we don't want. Use a debug section instead, the same as we do for .rmeta.
…ult-methods, r=oli-obk Mark defaulted `PartialEq`/`PartialOrd` methods as const WIthout it, `const` impls of these traits are unpleasant to write. I think this kind of change is allowed now. although it looks like it might require some Miri tweaks. Let's find out. r? ``@fee1-dead``
…estebank Improve suggestion to change struct field to &mut r? `@estebank` Now displays a proper underline style suggestion instead of including the code change inline with the message.
Remove `in_band_lifetimes` for `rustc_passes` rust-lang#91867
…=lnicola ⬆️ rust-analyzer r? ``@ghost``
…d, r=kennytm Revert "socket ancillary data implementation for dragonflybsd." Reverts rust-lang#91553
Use debug section for .rustc For a data section, the object crate will set SHF_ALLOC by default, which is exactly what we don't want. Use a debug section instead, the same as we do for .rmeta. I checked with `objdump -h` that this produces the right flags for ELF. Fixes rust-lang#92013.
Update stdlib to the 2021 edition progress towards rust-lang#88638 I couldnt find a way to run the 2018 style panic tests against 2018 so I just deleted them, maybe theres a way to do it that I missed though?
rustbot
added
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Dec 18, 2021
@bors r+ rollup=never p=7 |
📌 Commit db8c560 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Dec 18, 2021
You'll want to take #92029 out of this one, it failed in the previous rollup. |
Ah, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PartialEq
/PartialOrd
methods as const #91439 (Mark defaultedPartialEq
/PartialOrd
methods as const)in_band_lifetimes
forrustc_passes
#91896 (Removein_band_lifetimes
forrustc_passes
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup