-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #92106
Rollup of 4 pull requests #92106
Conversation
This crate actually had a typo `'ctx` in one of its functions: ```diff -pub fn same_type_modulo_infer(a: Ty<'tcx>, b: Ty<'ctx>) -> bool { +pub fn same_type_modulo_infer<'tcx>(a: Ty<'tcx>, b: Ty<'tcx>) -> bool { ```
For a data section, the object crate will set the SHF_ALLOC by default, which is exactly what we don't want. Explicitly set sh_flags to zero to avoid this.
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Fix an ICE when lowering a float with missing exponent magnitude This fixes: rust-lang#91434
…r=Aaron1011 Remove `in_band_lifetimes` from `rustc_infer` See rust-lang#91867 for more information. This crate actually had a typo `'ctx` in one of its functions: ```diff -pub fn same_type_modulo_infer(a: Ty<'tcx>, b: Ty<'ctx>) -> bool { +pub fn same_type_modulo_infer<'tcx>(a: Ty<'tcx>, b: Ty<'tcx>) -> bool { ``` Also, I wasn't entirely sure about the lifetimes in `suggest_new_region_bound`: ```diff pub fn suggest_new_region_bound( - tcx: TyCtxt<'tcx>, + tcx: TyCtxt<'_>, err: &mut DiagnosticBuilder<'_>, fn_returns: Vec<&rustc_hir::Ty<'_>>, ``` Should all of those lifetimes really be distinct?
Remove `in_band_lifetimes` for `rustc_monomorphize` rust-lang#91867
Explicitly set no ELF flags for .rustc section For a data section, the object crate will set the SHF_ALLOC by default, which is exactly what we don't want. Explicitly set sh_flags to zero to avoid this. I checked with `objdump -h` that this produces the right flags for ELF. Fixes rust-lang#92013.
@bors r+ rollup=never p=4 |
📌 Commit 9415c67 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e95e084): comparison url. Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Successful merges:
in_band_lifetimes
fromrustc_infer
#91878 (Removein_band_lifetimes
fromrustc_infer
)in_band_lifetimes
forrustc_monomorphize
#91895 (Removein_band_lifetimes
forrustc_monomorphize
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup