Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Stop ignoring Span field when hashing some Idents #92210

Closed
wants to merge 6 commits into from
Closed

[WIP] Stop ignoring Span field when hashing some Idents #92210

wants to merge 6 commits into from

Commits on Dec 24, 2021

  1. Stop ignoring Span field when hashing some Idents 

    This causes us to miss legitimate evaluatiosn (e.g. an upstream
`ExpnId` no longer exists), leading to ICEs when decoding stale
values from the incremental cache.
    @Aaron1011
    Aaron1011 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    ae17c8a View commit details
    Browse the repository at this point in the history

  2. Adjust some tests

    @Aaron1011
    Aaron1011 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    4ca8136 View commit details
    Browse the repository at this point in the history

  3. Fix hashing cache issue

    @Aaron1011
    Aaron1011 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    12bab02 View commit details
    Browse the repository at this point in the history

  4. Adjust incremental tests again

    @Aaron1011
    Aaron1011 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    3c7678b View commit details
    Browse the repository at this point in the history

  5. Fmt and warnings

    @Aaron1011
    Aaron1011 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    b50fd63 View commit details
    Browse the repository at this point in the history

  6. Ignore line length in test

    @Aaron1011
    Aaron1011 committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    7d18371 View commit details
    Browse the repository at this point in the history