Consolidate checking for msvc when generating debuginfo #92375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
wesleywiser
commented
Dec 28, 2021
wesleywiser
commented
Dec 28, 2021
There was a problem hiding this comment.
Thanks for the PR, @wesleywiser! Looks good.
r=me with the comments resolved.
michaelwoerister
added
S-waiting-on-author
If the target we're generating code for is msvc, then we do two main things differently: we generate type names in a C++ style instead of a Rust style and we generate debuginfo for enums differently. I've refactored the code so that there is one function (`cpp_like_debuginfo`) which determines if we should use the C++ style of naming types and other debuginfo generation or the regular Rust one.
wesleywiser
force-pushed
the
consolidate_debuginfo_msvc_check
branch
from
1aefa47 to
836addc
Compare
|
@bors r=michaelwoerister rollup |
|
📌 Commit 836addc has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2022
…svc_check, r=michaelwoerister Consolidate checking for msvc when generating debuginfo If the target we're generating code for is msvc, then we do two main things differently: we generate type names in a C++ style instead of a Rust style and we generate debuginfo for enums differently. I've refactored the code so that there is one function (`cpp_like_debuginfo`) which determines if we should use the C++ style of naming types and other debuginfo generation or the regular Rust one. r? `@michaelwoerister` This PR is not urgent so please don't let it interrupt your holidays! 🎄 🎁
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#84640 (Implement `TryFrom<char>` for `u8`) - rust-lang#92336 (Remove &self from PrintState::to_string) - rust-lang#92375 (Consolidate checking for msvc when generating debuginfo) - rust-lang#92568 (Add note about non_exhaustive to variant_count) - rust-lang#92600 (Add some missing `#[must_use]` to some `f{32,64}` operations) - rust-lang#92610 (Create CSS class instead of using inline style for search results) - rust-lang#92632 (Implement stabilization of `#[feature(available_parallelism)]`) - rust-lang#92650 (Fix typo in `StableCrateId` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the target we're generating code for is msvc, then we do two main
things differently: we generate type names in a C++ style instead of a
Rust style and we generate debuginfo for enums differently.
I've refactored the code so that there is one function
(
cpp_like_debuginfo) which determines if we should use the C++ styleof naming types and other debuginfo generation or the regular Rust one.
r? @michaelwoerister
This PR is not urgent so please don't let it interrupt your holidays! 🎄 🎁