Skip to content

remove in_band_lifetimes from librustdoc #92377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

remove in_band_lifetimes from librustdoc #92377

merged 1 commit into from
Dec 30, 2021

Conversation

compiler-errors
Copy link
Member

r? @camelid

closes #92368

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 28, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2021
camelid
camelid reviewed Dec 29, 2021
View reviewed changes
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2021
@compiler-errors
Copy link
Member Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 29, 2021
@camelid
Copy link
Member

camelid commented Dec 29, 2021

@bors r=camelid,jyn514

@bors
Copy link
Collaborator

bors commented Dec 29, 2021

📌 Commit bc7968f has been approved by camelid,jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2021
@camelid camelid added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Dec 29, 2021
@camelid
Copy link
Member

camelid commented Dec 29, 2021

Thanks!

@bors
Copy link
Collaborator

bors commented Dec 30, 2021

⌛ Testing commit bc7968f with merge 65d8785...

@bors
Copy link
Collaborator

bors commented Dec 30, 2021

☀️ Test successful - checks-actions
Approved by: camelid,jyn514
Pushing 65d8785 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2021
@bors bors merged commit 65d8785 into rust-lang:master Dec 30, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 30, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (65d8785): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@compiler-errors compiler-errors deleted the rustdoc-lifetimes branch April 7, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

Remove in_band_lifetimes from rustdoc
7 participants
@compiler-errors @rust-highfive @camelid @bors @rust-timer @jyn514 @rustbot