Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing of pretty printed const item without body #92414

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 29, 2021

Follow-up to #92238 fixing one of the FIXMEs.

macro_rules! repro {
    ($item:item) => {
        stringify!($item)
    };
}

fn main() {
    println!("{}", repro!(extern "C" { static S: i32; }));
}

Before: extern "C" { static S: i32 ; }
After: extern "C" { static S: i32; }

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 29, 2021
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2021
@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 30, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 30, 2021

📌 Commit b621635 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2021
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#91519 (ast: Avoid aborts on fatal errors thrown from mutable AST visitor)
 - rust-lang#92414 (Fix spacing of pretty printed const item without body)
 - rust-lang#92423 (Add UI test for rust-lang#92292)
 - rust-lang#92427 (Use `UnsafeCell::get_mut()` in `core::lazy::OnceCell::get_mut()`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e810487 into rust-lang:master Dec 30, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 30, 2021
@dtolnay dtolnay deleted the constnoexpr branch January 31, 2022 17:54
@dtolnay dtolnay added the A-pretty Area: Pretty printing (including `-Z unpretty`) label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants