Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test jemalloc's sized deallocation path. #92548

Closed
wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Jan 4, 2022

My local measurements showed that doing this was a slowdown. Let's see what happens on CI.

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 4, 2022
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 4, 2022
@bors
Copy link
Contributor

bors commented Jan 4, 2022

⌛ Trying commit 424c6c9 with merge 110536592fcd2f4d09f5646b980dd6546bd9a81f...

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rustc-main v0.0.0 (/checkout/compiler/rustc)
error[E0432]: unresolved import `tikv_jemallocator`
  --> compiler/rustc/src/main.rs:29:5
   |
29 | use tikv_jemallocator::Jemalloc;
   |     ^^^^^^^^^^^^^^^^^ use of undeclared crate or module `tikv_jemallocator`
error: unused import: `GlobalAlloc`
  --> compiler/rustc/src/main.rs:28:18
   |
28 | use std::alloc::{GlobalAlloc, Layout};
28 | use std::alloc::{GlobalAlloc, Layout};
   |                  ^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
For more information about this error, try `rustc --explain E0432`.
error: could not compile `rustc-main` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed

@bors
Copy link
Contributor

bors commented Jan 4, 2022

☀️ Try build successful - checks-actions
Build commit: 110536592fcd2f4d09f5646b980dd6546bd9a81f (110536592fcd2f4d09f5646b980dd6546bd9a81f)

@rust-timer
Copy link
Collaborator

Queued 110536592fcd2f4d09f5646b980dd6546bd9a81f with parent 2b681ac, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (110536592fcd2f4d09f5646b980dd6546bd9a81f): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 3.8% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 4, 2022
@nnethercote
Copy link
Contributor Author

Lots of performance regressions here, it matches closely what I saw locally, so that's a good confirmation that the sized deallocation is definitely not a win for rustc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants