-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Test jemalloc's sized deallocation path. #92548
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 424c6c9 with merge 110536592fcd2f4d09f5646b980dd6546bd9a81f... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
Queued 110536592fcd2f4d09f5646b980dd6546bd9a81f with parent 2b681ac, future comparison URL. |
Finished benchmarking commit (110536592fcd2f4d09f5646b980dd6546bd9a81f): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Lots of performance regressions here, it matches closely what I saw locally, so that's a good confirmation that the sized deallocation is definitely not a win for rustc. |
My local measurements showed that doing this was a slowdown. Let's see what happens on CI.
r? @ghost