Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 3151: Scoped threads. #92555

Merged
merged 18 commits into from
Jan 24, 2022
Merged

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jan 4, 2022

This implements rust-lang/rfcs#3151

Tracking issue: #93203

r? @Amanieu

It now panic!()s on its own, rather than resume_unwind'ing the panic
payload from the thread. Using resume_unwind skips the panic_handler,
meaning that the main thread would never have a panic handler run, which
can get confusing.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2022
@m-ou-se m-ou-se added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows labels Jan 4, 2022
@rust-log-analyzer

This comment has been minimized.

Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
Co-authored-by: deltragon <m@dafert.at>
Copy link
Contributor

@danielhenrymantilla danielhenrymantilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty slick!

library/std/src/thread/mod.rs Outdated Show resolved Hide resolved
library/std/src/thread/scoped.rs Show resolved Hide resolved
library/std/src/thread/scoped.rs Outdated Show resolved Hide resolved
library/std/src/thread/mod.rs Show resolved Hide resolved
library/std/src/thread/mod.rs Outdated Show resolved Hide resolved
library/std/src/thread/scoped.rs Show resolved Hide resolved
library/std/src/thread/scoped.rs Outdated Show resolved Hide resolved
library/std/src/thread/scoped.rs Outdated Show resolved Hide resolved
library/std/src/thread/scoped.rs Outdated Show resolved Hide resolved
library/std/src/thread/scoped.rs Outdated Show resolved Hide resolved
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
@m-ou-se m-ou-se mentioned this pull request Jan 22, 2022
10 tasks
@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2022
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 22, 2022

@Amanieu I've added the tracking issue number, so this is now ready for review/merging.

@Amanieu
Copy link
Member

Amanieu commented Jan 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 23, 2022

📌 Commit 465c405 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#91526 (rustc_lint: Some early linting refactorings)
 - rust-lang#92555 (Implement RFC 3151: Scoped threads.)
 - rust-lang#93213 (Fix `let_chains` and `if_let_guard` feature flags)
 - rust-lang#93219 (Add preliminary support for inline assembly for msp430.)
 - rust-lang#93226 (Normalize field access types during borrowck)
 - rust-lang#93227 (Liberate late bound regions when collecting GAT substs in wfcheck)
 - rust-lang#93229 (Remove DiagnosticBuilder.quiet)
 - rust-lang#93234 (rustc_mir_itertools: Avoid needless `collect` with itertools)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb260e8 into rust-lang:master Jan 24, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 24, 2022
@m-ou-se m-ou-se deleted the scoped-threads branch January 24, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.