improve _ constants in item signature handling
#92582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
added
A-diagnostics
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
lcnr
force-pushed
the
generic-arg-infer
branch
from
6c3fb3e
to
c0aa0fa
Compare
lcnr
changed the title
_ constants in signature handling_ constants in item signature handling
|
@bors r+ |
|
📌 Commit a3c55ac has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2022
improve `_` constants in item signature handling removing the "type" from the error messages does slightly worsen the error messages for types, but figuring out whether the placeholder is for a type or a constant and correctly dealing with that seemed fairly difficult to me so I took the easy way out ✨ Imo the error message is still clear enough. r? `@BoxyUwU` cc `@estebank`
|
@bors r- |
bors
added
S-waiting-on-author
lcnr
force-pushed
the
generic-arg-infer
branch
from
a3c55ac
to
641bba4
Compare
|
intra-doc links should be correct now: @bors r=BoxyUwU |
|
@bors r=BoxyUwU |
|
seems like bors is broken right now? cc @rust-lang/infra |
|
☔ The latest upstream changes (presumably #90986) made this pull request unmergeable. Please resolve the merge conflicts. |
|
If https://bors.rust-lang.org/queue/rust loads, you can typically close/reopen a PR to get bors to pick up new comments. It looks like this PR has a merge conflict though, anyway. |
lcnr
force-pushed
the
generic-arg-infer
branch
from
641bba4
to
217458b
Compare
|
@bors r=BoxyUwU |
|
📌 Commit 217458b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2022
…askrgr Rollup of 13 pull requests Successful merges: - rust-lang#89747 (Add MaybeUninit::(slice_)as_bytes(_mut)) - rust-lang#89764 (Fix variant index / discriminant confusion in uninhabited enum branching) - rust-lang#91606 (Stabilize `-Z print-link-args` as `--print link-args`) - rust-lang#91694 (rustdoc: decouple stability and const-stability) - rust-lang#92183 (Point at correct argument when async fn output type lifetime disagrees with signature) - rust-lang#92582 (improve `_` constants in item signature handling) - rust-lang#92680 (intra-doc: Use the impl's assoc item where possible) - rust-lang#92704 (Change lint message to be stronger for &T -> &mut T transmute) - rust-lang#92861 (Rustdoc mobile: put out-of-band info on its own line) - rust-lang#92992 (Help optimize out backtraces when disabled) - rust-lang#93038 (Fix star handling in block doc comments) - rust-lang#93108 (:arrow_up: rust-analyzer) - rust-lang#93112 (Fix CVE-2022-21658) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing the "type" from the error messages does slightly worsen the error messages for types, but figuring out whether the placeholder is for a type or a constant and correctly dealing with that seemed fairly difficult to me so I took the easy way out ✨ Imo the error message is still clear enough.
r? @BoxyUwU cc @estebank