Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new TaskDepsRef enum to track allow/ignore/forbid status #92681

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

Aaron1011
Copy link
Member

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 8, 2022
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2022
@Aaron1011
Copy link
Member Author

r? @cjgillot

@cjgillot
Copy link
Contributor

cjgillot commented Jan 9, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2022
@bors
Copy link
Contributor

bors commented Jan 9, 2022

⌛ Trying commit f64cd87 with merge f859e551c810093130909a29fc1064952b09ecbc...

@bors
Copy link
Contributor

bors commented Jan 9, 2022

☀️ Try build successful - checks-actions
Build commit: f859e551c810093130909a29fc1064952b09ecbc (f859e551c810093130909a29fc1064952b09ecbc)

@rust-timer
Copy link
Collaborator

Queued f859e551c810093130909a29fc1064952b09ecbc with parent 02fe61b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f859e551c810093130909a29fc1064952b09ecbc): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -1.4% on incr-unchanged builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Jan 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 9, 2022

📌 Commit f64cd87 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2022
@michaelwoerister
Copy link
Member

I didn't expect that to be a performance win 😃

@bors
Copy link
Contributor

bors commented Jan 14, 2022

⌛ Testing commit f64cd87 with merge 02c9e73...

@bors
Copy link
Contributor

bors commented Jan 14, 2022

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 02c9e73 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2022
@bors bors merged commit 02c9e73 into rust-lang:master Jan 14, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 14, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (02c9e73): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -1.4% on incr-unchanged builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants