- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Export tcp::IntoIncoming
          #92684
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
  
    Export tcp::IntoIncoming
  
  #92684
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) | 
              
                    m-ou-se
  
              
              requested changes
              
                  
                    Jan 12, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give the export the same #[unstable] tag as the type itself, to avoid giving the suggestion that this has been stable since 1.0.0.
| @bors r+ rollup | 
| 📌 Commit f88b501 has been approved by  | 
              
                    m-ou-se
  
              
              approved these changes
              
                  
                    Jan 14, 2022 
                  
              
              
            
            
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Jan 14, 2022 
    
    
      
  
    
      
    
  
Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Jan 14, 2022 
    
    
      
  
    
      
    
  
Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Jan 15, 2022 
    
    
      
  
    
      
    
  
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#92191 (Prefer projection candidates instead of param_env candidates for Sized predicates) - rust-lang#92382 (Extend const_convert to rest of blanket core::convert impls) - rust-lang#92625 (Add `#[track_caller]` to `mirbug`) - rust-lang#92684 (Export `tcp::IntoIncoming`) - rust-lang#92743 (Use pre-interned symbols in a couple of places) - rust-lang#92838 (Clean up some links in RELEASES) - rust-lang#92868 (librustdoc: Address some clippy lints) - rust-lang#92875 (Make `opt_const_param_of` work in the presence of `GenericArg::Infer`) - rust-lang#92891 (Add myself to .mailmap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-libs-api
  Relevant to the library API team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Added in #88339 but not publicly exported.