fix compilation errors of MIPS target #9277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I can imagine that this is going to just keep happening over time. We should probably decide to officially support mips (at least have a builder doing a cross-build), or that we're not officially supporting mips (although patches are always welcome). |
|
I don't think we can officially support MIPS at this time. I'm sorry for the breakage but our resources are limited. Patches are always welcome. |
bors
added a commit
that referenced
this pull request
Sep 18, 2013
This patch fixes some errors of MIPS target, however, MIPS C ABI is still broken. I will send another PR to fix the problem. Because MIPS target has no "generic" CPU name, I add --target-cpu and --target-feature to RUST_FLAGS. In order to workaround the "compact frame descriptions incompatible with DWARF2 .eh_frame" problem, the linker I used is CXX but not CC.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2022
… r=flip1995 add paren before '?' when suggesting deref for clone_on_copy changelog: none fixes rust-lang#9277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes some errors of MIPS target, however, MIPS C ABI is still broken. I will send another PR to fix the problem.
Because MIPS target has no "generic" CPU name, I add --target-cpu and --target-feature to RUST_FLAGS. In order to workaround the "compact frame descriptions incompatible with DWARF2 .eh_frame" problem, the linker I used is CXX but not CC.