-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump libc and fix remove_dir_all on Fuchsia after CVE fix #93351
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
Release 0.2.115 to crates.io. Needed by rust-lang/rust#93351. Should have included this in my prior PR but hadn't finished reading CONTRIBUTING.md. Sorry for the extra traffic!
5f41ad4
to
ac4cf3e
Compare
This comment has been minimized.
This comment has been minimized.
@bors r+ |
📌 Commit ac4cf3e8ebcb629c9655a78c6a2a55e7d6118435 has been approved by |
@bors rollup=iffy due to libc bump (probably fine, but there are a lot of commits) |
⌛ Testing commit ac4cf3e8ebcb629c9655a78c6a2a55e7d6118435 with merge 906ec76bee5a5ad501b5f67aa8e7706a9355b1a9... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
Gate PartialEq and Eq on freebsd objects behind extra_traits This fixes the failure in rust-lang/rust#93351 (comment). These derives were recently added in #2565. Other PartialEq/Eq derives in the project (and this file) are all behind the `extra_traits` gate.
With the previous `is_dir` impl, we would attempt to unlink a directory in the None branch, but Fuchsia supports returning ENOTEMPTY from unlinkat() without the AT_REMOVEDIR flag because we don't currently differentiate unlinking files and directories by default. On the Fuchsia side I've opened https://fxbug.dev/92273 to discuss whether this is the correct behavior, but it doesn't seem like addressing the error code is necessary to make our tests happy. Updates std's libc crate to include DT_UNKNOWN for Fuchsia.
ac4cf3e
to
8c9944c
Compare
@bors r+ rollup=never |
📌 Commit 8c9944c has been approved by |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Check failures seem to be from #93384 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ca43894): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
With the previous
is_dir
impl, we would attempt to unlinka directory in the None branch, but Fuchsia supports returning
ENOTEMPTY from unlinkat() without the AT_REMOVEDIR flag because
we don't currently differentiate unlinking files and directories
by default.
On the Fuchsia side I've opened https://fxbug.dev/92273 to discuss
whether this is the correct behavior, but it doesn't seem like
addressing the error code is necessary to make our tests happy.
Depends on rust-lang/libc#2654 since we
apparently haven't needed to reference DT_UNKNOWN before this.