Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store def_id_to_hir_id as variant in hir_owner. #93373

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Store def_id_to_hir_id as variant in hir_owner. #93373

merged 4 commits into from
Jan 31, 2022

Commits on Jan 27, 2022

  1. Store def_id_to_hir_id as variant in hir_owner. 

    If hir_owner is Owner(_), the LocalDefId is pointing to an owner, so the ItemLocalId is 0.
If the HIR node does not exist, we store Phantom.
Otherwise, we store the HirId associated to the LocalDefId.
    @cjgillot @spastorino
    cjgillot authored and spastorino committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    a0bcce4 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Separate hir_owner query into two queries to avoid using extensive da… 

    …ta on incr comp most of the time
    @spastorino
    spastorino committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    d17eb78 View commit details
    Browse the repository at this point in the history

  2. Make local_def_id_to_hir_id return MaybeOwner<()>

    @spastorino
    spastorino committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    5a299a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Make local_def_id_to_hir_id query directly returh HirId

    @spastorino
    spastorino committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    bf1ca2e View commit details
    Browse the repository at this point in the history