-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that #[rustc_must_implement_one_of]
is applied to a trait
#93386
Check that #[rustc_must_implement_one_of]
is applied to a trait
#93386
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
f0cd885
to
4ca56d2
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors try @rust-timer queue This is an internal attribute. While having checks is nice, lets make sure they do not cause slowdown in regular code. |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4ca56d2 with merge 347530806302cda50c5cf95d3b4b85b5ba54b360... |
☀️ Try build successful - checks-actions |
Queued 347530806302cda50c5cf95d3b4b85b5ba54b360 with parent 8c7f2bf, future comparison URL. |
Finished benchmarking commit (347530806302cda50c5cf95d3b4b85b5ba54b360): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 4ca56d2 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a6cd4aa): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
#[rustc_must_implement_one_of]
only makes sense when applied to a trait, so it's sensible to emit an error otherwise.