Skip to content

Conversation

cameron1024
Copy link
Contributor

Adds a regression test for issue #90847

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 27, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2022
@Mark-Simulacrum
Copy link
Member

This test seems like it may be in an odd directory? Could you move it to src/test/ui/const-generics/generic_const_exprs?

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2022
@cameron1024 cameron1024 force-pushed the issue-90847-regression branch from 18bf17a to 9118393 Compare January 31, 2022 17:02
@JohnCSimon
Copy link
Member

Ping from triage:
@cameron1024

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2022
@cameron1024
Copy link
Contributor Author

Ah thanks for letting me know, didn't know about that 😁

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 28, 2022

📌 Commit 9118393 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 28, 2022
… r=Mark-Simulacrum

regression for issue 90847

Adds a regression test for issue rust-lang#90847
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 28, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#89793 (Add `slice::{from_ptr_range, from_mut_ptr_range} `)
 - rust-lang#92642 (Update search location from a relative path to absolute)
 - rust-lang#93389 (regression for issue 90847)
 - rust-lang#93413 (Fix broken link from rustdoc docs to ayu theme)
 - rust-lang#94365 (Fix MinGW target detection in raw-dylib)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4115c3f into rust-lang:master Feb 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants