Move unstable is_{arch}_feature_detected! macros to std::arch #93414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
Jan 28, 2022
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
std_arch_detect
branch
from
5a22511 to
9a814b8
Compare
|
Links are fixed. |
|
@bors r+ |
|
📌 Commit 9a814b8 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 29, 2022
Move unstable is_{arch}_feature_detected! macros to std::arch
These macros are unstable, except for `is_x86_feature_detected` which is still exported from the crate root for backwards-compatibility.
This should unblock the stabilization of `is_aarch64_feature_detected`.
r? `@m-ou-se`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 29, 2022
Move unstable is_{arch}_feature_detected! macros to std::arch
These macros are unstable, except for `is_x86_feature_detected` which is still exported from the crate root for backwards-compatibility.
This should unblock the stabilization of `is_aarch64_feature_detected`.
r? ``@m-ou-se``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#93256 (Make `join!` description more accurate) - rust-lang#93358 (Add note suggesting that predicate may be satisfied, but is not `const`) - rust-lang#93362 (Do not register infer var for GAT projection in RPIT) - rust-lang#93391 (rustdoc: remove tooltip from source link) - rust-lang#93414 (Move unstable is_{arch}_feature_detected! macros to std::arch) - rust-lang#93441 (rustdoc: load the set of in-scope traits for modules with no docstring) - rust-lang#93459 (fs: Don't copy d_name from struct dirent) - rust-lang#93463 (Rename _args -> args in format_args expansion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Brooooooklyn
added a commit
to Brooooooklyn/crc32c
that referenced
this pull request
Feb 10, 2022
zowens
pushed a commit
to zowens/crc32c
that referenced
this pull request
Feb 15, 2022
Milerius
added a commit
to KomodoPlatform/komodo-defi-framework
that referenced
this pull request
Feb 21, 2022
artemii235
pushed a commit
to KomodoPlatform/komodo-defi-framework
that referenced
this pull request
Mar 23, 2022
* feat(unit_tests): add begin of unit test for spv proof * feat(utxo): continue test * feat(unit_tests): very wip * feat(utxo): merkle tree verification now work; need full refactoring * feat(spv): start spv validation module * feat(spv): add spv proof * feat(spv): add merkle proof unit test for a single element * feat(spv): add complex merkle proof inclusion unit test * feat(spv): fix some cargo warnings * feat(spv): simplify error check for validate_spv_proof - native client should not return error on validate_spv_proof since there is no verification * feat(spv): complete the first step of the spv proof validation * feat(spv): complete the unit test for spv proof validation in utxo module * feat(spv_validation): add vin and vout check for spv proof validation * feat(spv_validation): match exact error from the spv - will customize later * feat(utxo): start utxo block header storage + sync with dev * feat(utxo): continue block header storage interface * feat(utxo): revert sled - will switch to sqllite * feat(utxo): start utxo sql block header storage trait implementation * feat(sql): implement partially add_block_headers_to_storage and the unit test * feat(sql): add get_block header functions * feat(sql): add extra function for block insertion * feat(lib_bitcoin): add raw header type * feat(spv): Integrate raw block header into spv validation * feat(spv): remove old comments * feat(spv): Adding raw header into utxo_common spv validation * feat(spv): make slp great again * feat(spv): returning more concrete error types * feat(toolchain): update to `nightly-2022-02-01` to fix osx compilation - rust-lang/rust#93414 * feat(cargo): fix warnings * feat(fmt): rust fmt * feat(utxo_block_header): add a box dyn for block header storage to utxo common fields * Revert "feat(utxo_block_header): add a box dyn for block header storage to utxo common fields" This reverts commit 8914b76. * feat(utxo): add empty utxo_indexedb_block_header_storage.rs * feat(utxo): start an empty loop for downloading headers * feat(indexed_db_block_header): do not use todo to prevent crash at runtime * feat(block_header_loop): add block header loop in arc builder * feat(utxo): add a function to retrieve a storage from the ctx for block header * feat(utxo): start logic of block header downloading, very WIP * feat(header_validation): add partial header validation + params for enabling * feat(header_validation): add unexpected difficulty change check * feat(header_validation): add unit test for validate headers * feat(header_validation): document the validate_headers function * feat(header_validation): use appropriate error for validate_headers * feat(storage): rework storage to make it persistent * feat(storage): use the block header storage as optional and fix unit tests * feat(storage): make the conf into coins settings * feat(storage): implement header from storage or rpc + within validation * feat(improvements): remove non-used function * feat(storage): add to storage after validation in retrieve header from storage * feat(fix_review): first fixes batch * feat(fix_review): sql fixes + rename `from_address` to `sender_address` * feat(fix_review): simplify the way to get height, use into_iter + find * feat(fix_review): add a get_tx_height function + remove more marketcoinops in the arc builder * feat(fix_review): simplify download_loop with a `try_loop` macro * feat(fix_review): improve get_tx_height * feat(fix_review): continue review improvements, move retrieve_last_headers to electrum * feat(fix_review): remove dead code comment * feat(spv): next batch of fixes * feat(review): remove utxo_wrapper_block_header_storage.rs * feat(review): next batche of fixes * feat(review): refactor block_header_from_storage_or_rpc * feat(wasm): use explicitly instant wasm bindgen * feat(spv): fix wasm tests * feat(spv): fix unit test compilation * feat(eth): ignore polygon unit test (unstable) * feat(unit tests): increase to 6 seconds for the docker unit test * feat(utxo): simplify block_headers_storage, add error * feat(review): batch of review fixes * feat(review): another batch of review fixes * feat(eth_test): remove the loop * feat(eth_test): remove the loop * feat(spv_proof): review fixes * feat(spv_proof): review fixes * feat(spv): fix wrong copy paste description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros are unstable, except for
is_x86_feature_detectedwhich is still exported from the crate root for backwards-compatibility.This should unblock the stabilization of
is_aarch64_feature_detected.r? @m-ou-se