Restrict query recursion in needs_significant_drop

[JakobDegen]

Overly aggressive use of the query system to improve caching lead to query cycles and consequently ICEs. This patch fixes this by restricting the use of the query system as a cache to those cases where it is definitely correct.

Closes #92725 .

This is essentially a revert of #90845 for the significant drop case only. The general needs_drop still does the same thing. The hope is that this is enough to preserve the performance improvements of that PR while fixing the ICE. Should get a perf run to verify that this is the case.

cc @cjgillot

[rust-highfive]

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 56ed8dc9e526e7a3a2546079781d417b220ad523 with merge 353c871303d82172f5490ff4d58c72a101481398...

[bors]

☀️ Try build successful - checks-actions
Build commit: 353c871303d82172f5490ff4d58c72a101481398 (353c871303d82172f5490ff4d58c72a101481398)

[rust-timer]

Queued 353c871303d82172f5490ff4d58c72a101481398 with parent d08e816, future comparison URL.

[rust-timer]

Finished benchmarking commit (353c871303d82172f5490ff4d58c72a101481398): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[cjgillot]

Sorry @JakobDegen, I had forgotten about this PR.
Could you rebase the PR to pre-start CI?
Perf is green. I'll approve then.

[JakobDegen]

Rebased

[cjgillot]

@bors r+

[bors]

📌 Commit 5952d71 has been approved by cjgillot

[bors]

⌛ Testing commit 5952d71 with merge 10cc7a6...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 10cc7a6 to master...

[rust-timer]

Finished benchmarking commit (10cc7a6): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression