Add a new Digest.result_bytes convenience function. #9345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? |
|
I'm a little hesitant about how much we want to pursue these crypto-related functions. I think we've started to settle on not rolling our own crypto, so I'm not sure how much we want to pursue the convenience of these libraries. I can't imagine that there's any security reason to deny this, but I'm also not confident saying that. The patch itself looks fine, to me it's a matter of more whether we wish to pursue maintenance of these modules. |
|
Assuming that the crypto libraries will be overhauled, this method would be useful (at least to me) until that point. 🍰 |
bors
added a commit
that referenced
this pull request
Sep 25, 2013
I would find this function useful.
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 29, 2022
Fix typo in as_undescore docs *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would find this function useful.