Skip pointing out ambiguous impls in alloc/std crates too in inference errors #93469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the logic in
annotate_source_of_ambiguity
to skip printing ambiguity errors traits inalloc
andstd
as well, not justcore
.While this does spot-fix the issue mentioned below, it would be nicer to generalize this logic, for example to detect when the trait predicate's
self_ty
has any numerical inference variables. Is it worthwhile to scrap this solution for one like that?Fixes #93450
r? @estebank
feel free to reassign