Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect panic message in example #93531

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Fix incorrect panic message in example #93531

merged 1 commit into from
Feb 2, 2022

Conversation

TheColdVoid
Copy link
Contributor

The panic message when calling the connect() should probably be a message about connection failure, not a message about binding address failure.

@ehuss
Copy link
Contributor

ehuss commented Feb 1, 2022

r? libs

@m-ou-se
Copy link
Member

m-ou-se commented Feb 1, 2022

Thanks!

@bors r+ rollup

(This reminds me that we're not very consistent with capitalization and punctuation in the expect/panic messages in the standard library examples. This patch is consistent with the other examples about a connection failure, but we might want to clean all the examples up at some point and settle on one style for all our example panic messages.)

@bors
Copy link
Contributor

bors commented Feb 1, 2022

📌 Commit 76aa929 has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 1, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 2, 2022
Fix incorrect panic message in example

The panic message when calling the `connect()` should probably be a  message about connection failure, not a message about binding address failure.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2022
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#92758 (librustdoc: impl core::fmt::Write for rustdoc::html::render::Buffer)
 - rust-lang#92788 (Detect `::` -> `:` typo in type argument)
 - rust-lang#93420 (Improve wrapping on settings page)
 - rust-lang#93493 (Document valid values of the char type)
 - rust-lang#93531 (Fix incorrect panic message in example)
 - rust-lang#93559 (Add missing | between print options)
 - rust-lang#93560 (Fix two incorrect "it's" (typos in comments))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b836b28 into rust-lang:master Feb 2, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants