Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize let else #93628

Merged
merged 5 commits into from
Sep 17, 2022
Merged

Stabilize let else #93628

merged 5 commits into from
Sep 17, 2022

Commits on Sep 15, 2022

  1. Stabilize the let_else feature

    @est31
    est31 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    bca3cf7 View commit details
    Browse the repository at this point in the history

  2. Remove feature gate from let else suggestion 

    The let else suggestion added by 0d92752
does not need a feature gate any more.
    @est31
    est31 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    5633e86 View commit details
    Browse the repository at this point in the history

  3. Only enable the let_else feature on bootstrap 

    On later stages, the feature is already stable.

Result of running:

rg -l "feature.let_else" compiler/ src/librustdoc/ library/ | xargs sed -s -i "s#\\[feature.let_else#\\[cfg_attr\\(bootstrap, feature\\(let_else\\)#"
    @est31
    est31 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    173eb6f View commit details
    Browse the repository at this point in the history

  4. Remove the let_else feature gate from the testsuite 

    Result of running:

rg -l "feature.let_else" src/test/  | xargs sed -s -i "s#^...feature.let_else..\$##"

Plus manual tidy fixes.
    @est31
    est31 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    9c7ae38 View commit details
    Browse the repository at this point in the history

  5. Fix clippy

    @est31
    est31 committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    37dde3f View commit details
    Browse the repository at this point in the history