compiler: clippy::complexity fixes #93634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
useless_format map_flatten useless_conversion needless_bool filter_next clone_on_copy needless_option_as_deref
matthiaskrgr
commented
Feb 3, 2022
Comment on lines
-223
to
+232
| let dead_code_cgu = if let Some(cgu) = cgus | ||
| .into_iter() | ||
| .rev() | ||
| .filter(|cgu| cgu.items().iter().any(|(_, (linkage, _))| *linkage == Linkage::External)) | ||
| .next() | ||
| { | ||
| cgu | ||
| } else { | ||
| // If there are no CGUs that have externally linked items, | ||
| // then we just pick the first CGU as a fallback. | ||
| &mut post_inlining.codegen_units[0] | ||
| }; | ||
| let dead_code_cgu = | ||
| if let Some(cgu) = cgus.into_iter().rev().find(|cgu| { | ||
| cgu.items().iter().any(|(_, (linkage, _))| *linkage == Linkage::External) | ||
| }) { | ||
| cgu | ||
| } else { | ||
| // If there are no CGUs that have externally linked items, | ||
| // then we just pick the first CGU as a fallback. | ||
| &mut post_inlining.codegen_units[0] | ||
| }; |
There was a problem hiding this comment.
any().next() -> find() here
matthiaskrgr
force-pushed
the
clippy_complexity_jan_2022
branch
from
c37c45d
to
b80057d
Compare
|
r? @oli-obk |
|
@bors r+ |
|
📌 Commit b80057d has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 17, 2022
…2022, r=oli-obk compiler: clippy::complexity fixes useless_format map_flatten useless_conversion needless_bool filter_next clone_on_copy needless_option_as_deref
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#92683 (Suggest copying trait associated type bounds on lifetime error) - rust-lang#92933 (Deny mixing bin crate type with lib crate types) - rust-lang#92959 (Add more info and suggestions to use of #[test] on invalid items) - rust-lang#93024 (Do not ICE when inlining a function with un-satisfiable bounds) - rust-lang#93613 (Move `{core,std}::stream::Stream` to `{core,std}::async_iter::AsyncIterator`) - rust-lang#93634 (compiler: clippy::complexity fixes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useless_format
map_flatten
useless_conversion
needless_bool
filter_next
clone_on_copy
needless_option_as_deref