Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in ValuePair::Term #93728

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Add in ValuePair::Term #93728

merged 2 commits into from
Feb 8, 2022

Conversation

JulianKnodt
Copy link
Contributor

This adds in an enum when matching on positions which can either be types or consts.
It will default to emitting old special cased error messages for types.

r? @oli-obk
cc @matthiaskrgr
Fixes #93578

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2022
This adds in an enum when matching on positions which can either be types or consts.
It will default to emitting old special cased error messages for types.
Remove old value pairs which is a strict subset of Terms.
@oli-obk
Copy link
Contributor

oli-obk commented Feb 7, 2022

Awesome!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 7, 2022

📌 Commit be236d7 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2022
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#86497 (Add {floor,ceil}_char_boundary methods to str)
 - rust-lang#92695 (Add `#[no_coverage]` tests for nested functions)
 - rust-lang#93521 (Fix hover effects in sidebar)
 - rust-lang#93568 (Include all contents of first line of scraped item in Rustdoc)
 - rust-lang#93569 (rustdoc: correct unclosed HTML tags as generics)
 - rust-lang#93672 (update comment wrt const param defaults)
 - rust-lang#93715 (Fix horizontal trim for block doc comments)
 - rust-lang#93721 (rustdoc: Special-case macro lookups less)
 - rust-lang#93728 (Add in ValuePair::Term)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 25ce315 into rust-lang:master Feb 8, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 8, 2022
@JulianKnodt JulianKnodt deleted the toterm branch February 8, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: assoc-const-ty-mismatch.rs -Zsave-analysis: 'not yet implemented', compiler/rustc_infer/src/infer/at.rs
5 participants