Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fut/back compat tests for implied trait bounds #93732

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 7, 2022

the guard test was tested to cause a segfault with -Zchalk, very nice

cc @nikomatsakis #44491 #25860

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 7, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2022
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me (mostly just rubber stamping) with nit fixed

@lcnr
Copy link
Contributor Author

lcnr commented Feb 7, 2022

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Feb 7, 2022

📌 Commit c2a8077b44680fcd029714030b2722645b07d769 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2022
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member

@bors r- (per tidy failure)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Feb 8, 2022

woops, thanks 👍

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Feb 8, 2022

📌 Commit af9e30a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2022
add fut/back compat tests for implied trait bounds

the `guard` test was tested to cause a segfault with `-Zchalk`, very nice

cc `@nikomatsakis` rust-lang#44491 rust-lang#25860
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2022
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91950 (Point at type when a `static` `#[global_allocator]` doesn't `impl` `GlobalAlloc`)
 - rust-lang#92715 (Do not suggest char literal for zero-length strings)
 - rust-lang#92917 (Don't constrain projection predicates with inference vars in GAT substs)
 - rust-lang#93206 (Use `NtCreateFile` instead of `NtOpenFile` to open a file)
 - rust-lang#93732 (add fut/back compat tests for implied trait bounds)
 - rust-lang#93764 (:arrow_up: rust-analyzer)
 - rust-lang#93767 (deduplicate `lcnr` in mailmap)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e881d65 into rust-lang:master Feb 9, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants